* [RAUC] [PATCH] src/mark: fix double freeing
@ 2018-03-12 19:28 Andreas Schmidt
2018-03-13 9:45 ` Jan Lübbe
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schmidt @ 2018-03-12 19:28 UTC (permalink / raw)
To: rauc
While calling `rauc status mark-xxx <invalid slot>` rauc crashs,
because of double freeing of GError struct. This patch fix this.
Signed-off-by: Andreas Schmidt <mail@schmidt-andreas.de>
---
src/mark.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mark.c b/src/mark.c
index 5418cfe..efbe233 100644
--- a/src/mark.c
+++ b/src/mark.c
@@ -127,7 +127,6 @@ gboolean mark_run(const gchar *state,
if (ierror) {
res = FALSE;
*message = g_strdup(ierror->message);
- g_error_free(ierror);
goto out;
}
--
2.14.1
_______________________________________________
RAUC mailing list
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RAUC] [PATCH] src/mark: fix double freeing
2018-03-12 19:28 [RAUC] [PATCH] src/mark: fix double freeing Andreas Schmidt
@ 2018-03-13 9:45 ` Jan Lübbe
0 siblings, 0 replies; 2+ messages in thread
From: Jan Lübbe @ 2018-03-13 9:45 UTC (permalink / raw)
To: rauc
On Mon, 2018-03-12 at 20:28 +0100, Andreas Schmidt wrote:
> While calling `rauc status mark-xxx <invalid slot>` rauc crashs,
> because of double freeing of GError struct. This patch fix this.
>
> Signed-off-by: Andreas Schmidt <mail@schmidt-andreas.de>
> ---
> src/mark.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/mark.c b/src/mark.c
> index 5418cfe..efbe233 100644
> --- a/src/mark.c
> +++ b/src/mark.c
> @@ -127,7 +127,6 @@ gboolean mark_run(const gchar *state,
> if (ierror) {
> res = FALSE;
> *message = g_strdup(ierror->message);
> - g_error_free(ierror);
> goto out;
> }
Thanks, applied!
Regards,
Jan
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
RAUC mailing list
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-13 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-12 19:28 [RAUC] [PATCH] src/mark: fix double freeing Andreas Schmidt
2018-03-13 9:45 ` Jan Lübbe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox