From: "Jan Lübbe" <jlu@pengutronix.de>
To: rauc@pengutronix.de
Subject: Re: [RAUC] [PATCH] src/mark: fix double freeing
Date: Tue, 13 Mar 2018 10:45:12 +0100 [thread overview]
Message-ID: <1520934312.7326.7.camel@pengutronix.de> (raw)
In-Reply-To: <20180312192814.2943-1-mail@schmidt-andreas.de>
On Mon, 2018-03-12 at 20:28 +0100, Andreas Schmidt wrote:
> While calling `rauc status mark-xxx <invalid slot>` rauc crashs,
> because of double freeing of GError struct. This patch fix this.
>
> Signed-off-by: Andreas Schmidt <mail@schmidt-andreas.de>
> ---
> src/mark.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/mark.c b/src/mark.c
> index 5418cfe..efbe233 100644
> --- a/src/mark.c
> +++ b/src/mark.c
> @@ -127,7 +127,6 @@ gboolean mark_run(const gchar *state,
> if (ierror) {
> res = FALSE;
> *message = g_strdup(ierror->message);
> - g_error_free(ierror);
> goto out;
> }
Thanks, applied!
Regards,
Jan
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
RAUC mailing list
prev parent reply other threads:[~2018-03-13 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 19:28 Andreas Schmidt
2018-03-13 9:45 ` Jan Lübbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520934312.7326.7.camel@pengutronix.de \
--to=jlu@pengutronix.de \
--cc=rauc@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox