mail archive of the rauc mailing list
 help / color / mirror / Atom feed
From: Andreas Schmidt <mail@schmidt-andreas.de>
To: rauc@pengutronix.de
Subject: [RAUC] [PATCH] src/mark: fix double freeing
Date: Mon, 12 Mar 2018 20:28:14 +0100	[thread overview]
Message-ID: <20180312192814.2943-1-mail@schmidt-andreas.de> (raw)

While calling `rauc status mark-xxx <invalid slot>` rauc crashs,
because of double freeing of GError struct. This patch fix this.

Signed-off-by: Andreas Schmidt <mail@schmidt-andreas.de>
---
 src/mark.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mark.c b/src/mark.c
index 5418cfe..efbe233 100644
--- a/src/mark.c
+++ b/src/mark.c
@@ -127,7 +127,6 @@ gboolean mark_run(const gchar *state,
 	if (ierror) {
 		res = FALSE;
 		*message = g_strdup(ierror->message);
-		g_error_free(ierror);
 		goto out;
 	}
 
-- 
2.14.1


_______________________________________________
RAUC mailing list

             reply	other threads:[~2018-03-12 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 19:28 Andreas Schmidt [this message]
2018-03-13  9:45 ` Jan Lübbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312192814.2943-1-mail@schmidt-andreas.de \
    --to=mail@schmidt-andreas.de \
    --cc=rauc@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox