mail archive of the rauc mailing list
 help / color / mirror / Atom feed
* [RAUC] remove trailing whitespaces at slot-type
@ 2021-03-16 12:25 Stahl, Michael
  2021-03-16 12:36 ` Enrico Jörns
  0 siblings, 1 reply; 2+ messages in thread
From: Stahl, Michael @ 2021-03-16 12:25 UTC (permalink / raw)
  To: RAUC


[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]

I just searched some hours because rauc wount update my rootfs. The message was:
Installation error: Unsupported image /run/rauc/bundle/MyRootfs.tar.gz

I found out that I had some trailing whitespaces in the system.conf at type=ext4
Because of that the g_pattern_match_simpel function in get_update_handler (update_handler.c) didn't match.

Maybe it is possible to remove trailing whitespaces before calling g_pattern_match_simple function in future.






[-- Attachment #1.2: Type: text/html, Size: 1828 bytes --]

[-- Attachment #2: Type: text/plain, Size: 66 bytes --]

_______________________________________________
RAUC mailing list

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RAUC] remove trailing whitespaces at slot-type
  2021-03-16 12:25 [RAUC] remove trailing whitespaces at slot-type Stahl, Michael
@ 2021-03-16 12:36 ` Enrico Jörns
  0 siblings, 0 replies; 2+ messages in thread
From: Enrico Jörns @ 2021-03-16 12:36 UTC (permalink / raw)
  To: Stahl, Michael, RAUC

Hi Michael,

Am Dienstag, dem 16.03.2021 um 12:25 +0000 schrieb Stahl, Michael:
> I just searched some hours because rauc wount update my rootfs. The message
> was:
> Installation error: Unsupported image /run/rauc/bundle/MyRootfs.tar.gz
> 
> I found out that I had some trailing whitespaces in the system.conf at
> type=ext4 
> Because of that the g_pattern_match_simpel function in get_update_handler
> (update_handler.c) didn't match.
> 
> Maybe it is possible to remove trailing whitespaces before calling
> g_pattern_match_simple function in future.

thanks for reporting this. Yes, this actually sounds reasonable to me.

If you would like to make a patch for this, also please feel free to contribute.

My guess would be we should do this during config file parsing already
(config_file.c) as having leading/trailing whitespaces in values is probably
wrong for almost all options.

So far we do this only for the system variant during context setup.


Best regards

Enrico



-- 
Pengutronix e.K.                           | Enrico Jörns                |
Embedded Linux Consulting & Support        | https://www.pengutronix.de/ |
Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |


_______________________________________________
RAUC mailing list

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-16 12:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 12:25 [RAUC] remove trailing whitespaces at slot-type Stahl, Michael
2021-03-16 12:36 ` Enrico Jörns

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox