Re: [RAUC] remove trailing whitespaces at slot-type

["Enrico Jörns" <ejo@pengutronix.de>]

Hi Michael,

Am Dienstag, dem 16.03.2021 um 12:25 +0000 schrieb Stahl, Michael:
> I just searched some hours because rauc wount update my rootfs. The message
> was:
> Installation error: Unsupported image /run/rauc/bundle/MyRootfs.tar.gz
> 
> I found out that I had some trailing whitespaces in the system.conf at
> type=ext4 
> Because of that the g_pattern_match_simpel function in get_update_handler
> (update_handler.c) didn't match.
> 
> Maybe it is possible to remove trailing whitespaces before calling
> g_pattern_match_simple function in future.

thanks for reporting this. Yes, this actually sounds reasonable to me.

If you would like to make a patch for this, also please feel free to contribute.

My guess would be we should do this during config file parsing already
(config_file.c) as having leading/trailing whitespaces in values is probably
wrong for almost all options.

So far we do this only for the system variant during context setup.


Best regards

Enrico



-- 
Pengutronix e.K.                           | Enrico Jörns                |
Embedded Linux Consulting & Support        | https://www.pengutronix.de/ |
Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |


_______________________________________________
RAUC mailing list