mail archive of the rauc mailing list
 help / color / mirror / Atom feed
From: Enrico Joerns <ejo@pengutronix.de>
To: "Middelschulte, Leif" <Leif.Middelschulte@klsmartin.com>
Cc: "rauc@pengutronix.de" <rauc@pengutronix.de>
Subject: Re: [RAUC] Progress indication
Date: Wed, 10 May 2017 15:22:13 +0200	[thread overview]
Message-ID: <382dd7e9-7505-80b9-2465-ac1c019ad115@pengutronix.de> (raw)
In-Reply-To: <1493908382.31913.1.camel@klsmartin.com>

Hi Leif,

On 05/04/2017 04:33 PM, Middelschulte, Leif wrote:
>
> Now, about my second question: How does a custom hook script communicate its progress back to the install-handler (i.e. rauc service)?
>
> I'd go modify rauc's update_handler.c, set the G_SUBPROCESS_FLAGS_STDOUT_PIPE flag for the spawned slot script-process and read back the progress and propagate it to the DBus interface using
> r_context_send_progress.
> Is that the right direction here?

in RAUC, the progress is generated by adding a 'step' for an action you 
perform.
When starting the action you call r_context_begin_step(), when 
terminating the action you call r_context_end_step(). It is important to 
know that steps have a nesting depth that allows visualizers to control 
the granularity of information they show.
A step can also be marked as either successful or failed.


An example is the "Determining slot states" step:

   r_context_begin_step("determine_slot_states", "Determining slot 
states", 0);
   [...]
   r_context_end_step("determine_slot_states", res);


Thus, this should be the interface to use to add new steps.


The current granularity we have does not go deeper than "Copying image". 
This will be called for both a default install handler as well as for an 
install hook.

If you ask for progress from the install hook, you intend to be more 
fine-grained with your messages?

Best regards, Enrico


-- 
Pengutronix e.K.                           | Enrico Jörns                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5080 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
RAUC mailing list

  reply	other threads:[~2017-05-10 13:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 16:03 Middelschulte, Leif
2017-05-04 10:29 ` Enrico Joerns
2017-05-04 14:33   ` Middelschulte, Leif
2017-05-10 13:22     ` Enrico Joerns [this message]
2017-05-11 10:29       ` Middelschulte, Leif
2017-05-16  9:21         ` Enrico Joerns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=382dd7e9-7505-80b9-2465-ac1c019ad115@pengutronix.de \
    --to=ejo@pengutronix.de \
    --cc=Leif.Middelschulte@klsmartin.com \
    --cc=rauc@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox